Changeset 649580

Timestamp:

04/27/10 11:00:14 (3 years ago)

Author:

Dan Dennedy <dan@…>

Branches:

b1faa09f4dfcf63d19d2cb9fc598a583e1df1c33

Children:

7186a8

Parents:

a11a00

git-author:

Dan Dennedy <dan@…> (04/27/10 11:00:14)

git-committer:

Dan Dennedy <dan@…> (04/27/10 11:00:14)

Message:

Fix uninitalized variables in C++ filters.

Patch from Burkhard Plaum with note:
This patch fixes some uninitialized variable problems,
which caused valgrind warnings for me. In C all filters are now allocated
with calloc, unfortunately C++ doesn't have a new0 operator :)

It simply sets the values to zero in the constructors. The exception is
water.cpp: The parameter "splash" isn't used at all, so I kicked it out.

Location:

src/filter

Files:

• delay0r/delay0r.cpp (modified) (1 diff)
• edgeglow/edgeglow.cpp (modified) (1 diff)
• nosync0r/nosync0r.cpp (modified) (1 diff)
• water/water.cpp (modified) (2 diffs)

src/filter/delay0r/delay0r.cpp

@@ -11 +11 @@
   delay0r(unsigned int width, unsigned int height)
   {
+    delay = 0.0;
     register_param(delay,"DelayTime","the delay time");
   }

src/filter/edgeglow/edgeglow.cpp

@@ -40 +40 @@
   edgeglow(unsigned int width, unsigned int height)
   {
+    lthresh = 0.0;
+    lupscale = 0.0;
+    lredscale = 0.0;
     register_param(lthresh, "lthresh", "threshold for edge lightening");
     register_param(lupscale, "lupscale", "multiplier for upscaling edge brightness");

src/filter/nosync0r/nosync0r.cpp

@@ -9 +9 @@
   nosync0r(unsigned int width, unsigned int height)
   {
+    hsync = 0.0;
     register_param(hsync,"HSync","the hsync offset");
   }

src/filter/water/water.cpp

@@ -67 +67 @@
 public:
 
-  f0r_param_position splash;
   f0r_param_double physics;
   bool rain;
@@ -77 +76 @@
 
   Water(unsigned int width, unsigned int height) {
-    register_param(splash, "splash", "make a big splash in the center");
+    physics = 0.0;
     register_param(physics, "physics", "water density: from 1 to 4");
     register_param(rain, "rain", "rain drops all over");