Modify ↓

Ticket #29 (closed defect: fixed)

Opened 20 months ago

Last modified 8 months ago

Undefined behavior in some plugins

Reported by: reddwarf@… Owned by: somebody
Priority: major Milestone: version 1.2
Component: filter Version: 1.2
Keywords: Cc:

Description

The attached patch fixes warnings as "filter/curves/curves.c:459:29: warning: operation on 'offset' may be undefined"

Notice I didn't tried to understand the code. So I'm really unsure if

dst[offset] = (dst[offset++] >> 1) + 0x7F;

was expected to mean

dst[offset+1] = (dst[offset] >> 1) + 0x7F; offset++;

or

dst[offset] = (dst[offset] >> 1) + 0x7F; offset++;

Attachments

frei0r-plugins-1.2-undefined.patch Download (1.8 KB) - added by reddwarf@… 20 months ago.

Change History

Changed 20 months ago by reddwarf@…

comment:1 Changed 8 months ago by dan@…

Fixed in git commit 8f809085bf1ca0f3d4a7b5bade3afe2367c3e9b2

comment:2 Changed 8 months ago by Dan Dennedy <dan@…>

  • Status changed from new to closed
  • Resolution set to fixed
View ↑

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.